Skip to content

Conversation

@justinmayer
Copy link
Contributor

@justinmayer justinmayer commented Nov 5, 2019

If you're adding a project to the Python 3 statement, please ensure you have:

  • Discussed dropping Python 2 support with all maintainers
  • Discussed signing the statement with all maintainers
  • Added a suitable logo if the project has one
    • Approximately square logos generally fit better than banners
    • Compressed the logo to save bandwidth (run scripts/squash-images.sh on it)
  • Checked the Netlify preview made from the pull request

@justinmayer
Copy link
Contributor Author

Preview looks good, so everything should be all set here. Many thanks for all your work on this endeavor, @takluyver! 👏

@takluyver
Copy link
Member

Thanks! This all looks good to me. I'll leave it for a day or so, though, as I see your 'unless there are any objections' post was just a couple of hours ago. If I forget about it, please ping to remind me.

It's not just me - I've been clicking the merge button a lot lately, but @Carreau and @asmeurer did more to get the initiative off the ground, and several other people have contributed significantly.

@justinmayer
Copy link
Contributor Author

Sincere apologies to @Carreau and @asmeurer for the oversight! Your work on this project is indeed much appreciated.

I've heard nothing but enthusiastic support among fellow Pelican Dev Team members for dropping Python 2, so I think it's safe to say that this PR can be merged. Many thanks for adding Pelican to the list! 😁

@takluyver takluyver merged commit d593248 into python3statement:master Nov 8, 2019
@takluyver
Copy link
Member

Thanks!

@justinmayer justinmayer deleted the pelican branch November 9, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants